Refactor inline editing into shared hook
All checks were successful
Deploy Sokko G / deploy (push) Successful in 7s
All checks were successful
Deploy Sokko G / deploy (push) Successful in 7s
This commit is contained in:
parent
1879b245fb
commit
1e4ac4259b
9 changed files with 239 additions and 205 deletions
|
|
@ -14,6 +14,7 @@ test("toolbox storage, cards and pages are wired", async () => {
|
|||
const importButton = await readFile("website/src/components/ImportButton.jsx", "utf8");
|
||||
const reorderHook = await readFile("website/src/hooks/usePointerReorder.js", "utf8");
|
||||
const groupedReorderHook = await readFile("website/src/hooks/useGroupedReorder.js", "utf8");
|
||||
const inlineEditHook = await readFile("website/src/hooks/useInlineEdit.js", "utf8");
|
||||
|
||||
assert.match(`${indexedToolboxesHook}\n${toolboxPages}`, /indexedDbStorage\.js/);
|
||||
assert.match(source, /features\/toolboxes\/storage\/useIndexedToolboxes\.js/);
|
||||
|
|
@ -55,6 +56,8 @@ test("toolbox storage, cards and pages are wired", async () => {
|
|||
assert.match(toolboxPages, /\.\/ToolboxCard\.jsx/);
|
||||
assert.match(toolboxPages, /updateToolboxOrder/);
|
||||
assert.match(toolboxPages, /useGroupedReorder/);
|
||||
assert.match(toolboxPages, /useInlineEdit/);
|
||||
assert.match(toolboxPages, /getContentEditableProps/);
|
||||
assert.match(toolboxPages, /orientation: "horizontal"/);
|
||||
assert.match(toolboxPages, /components\/StorageQuota\.jsx/);
|
||||
assert.match(toolboxPages, /components\/ImportButton\.jsx/);
|
||||
|
|
@ -82,6 +85,11 @@ test("toolbox storage, cards and pages are wired", async () => {
|
|||
assert.match(groupedReorderHook, /export function applyGroupedReorderOperation/);
|
||||
assert.match(groupedReorderHook, /data-reorder-orientation/);
|
||||
assert.match(groupedReorderHook, /operation\.sourceParentId === operation\.targetParentId/);
|
||||
assert.match(inlineEditHook, /export function useInlineEdit/);
|
||||
assert.match(inlineEditHook, /skipCommitRef/);
|
||||
assert.match(inlineEditHook, /blurOnEscape/);
|
||||
assert.match(inlineEditHook, /commitOnEnter/);
|
||||
assert.match(inlineEditHook, /getContentEditableProps/);
|
||||
});
|
||||
|
||||
test("toolbox module registry and modules expose expected behavior", async () => {
|
||||
|
|
@ -126,6 +134,8 @@ test("toolbox module registry and modules expose expected behavior", async () =>
|
|||
assert.match(moduleRegistry, /itemReorder\.startDrag/);
|
||||
assert.match(moduleRegistry, /onPointerDown/);
|
||||
assert.match(moduleRegistry, /useGroupedReorder/);
|
||||
assert.match(moduleRegistry, /useInlineEdit/);
|
||||
assert.match(moduleRegistry, /getContentEditableProps/);
|
||||
assert.match(moduleRegistry, /tool-add-card/);
|
||||
assert.match(moduleRegistry, /tool-quick-add-button/);
|
||||
assert.match(moduleRegistry, /tool-add-quick-toggle/);
|
||||
|
|
@ -143,6 +153,7 @@ test("toolbox module registry and modules expose expected behavior", async () =>
|
|||
assert.match(combosModule, /ComboSequence/);
|
||||
assert.match(combosModule, /keyboardLayout/);
|
||||
assert.match(combosModule, /simultaneousMode/);
|
||||
assert.match(combosModule, /useInlineEdit/);
|
||||
assert.match(combosModule, /useGroupedReorder/);
|
||||
assert.match(combosModule, /reorderFeatures/);
|
||||
assert.doesNotMatch(combosModule, /canMoveItem:/);
|
||||
|
|
@ -151,6 +162,7 @@ test("toolbox module registry and modules expose expected behavior", async () =>
|
|||
assert.match(calculatorModule, /calculateExpression/);
|
||||
assert.match(calculatorModule, /activeParentId/);
|
||||
assert.match(calculatorModule, /parentId/);
|
||||
assert.match(calculatorModule, /useInlineEdit/);
|
||||
assert.match(calculatorModule, /useGroupedReorder/);
|
||||
assert.match(calculatorModule, /calculator-drag-handle/);
|
||||
assert.match(calculatorModule, /scrollResults/);
|
||||
|
|
@ -186,6 +198,7 @@ test("toolbox module registry and modules expose expected behavior", async () =>
|
|||
assert.match(tableModule, /ArrowLeft/);
|
||||
assert.match(tableModule, /ArrowRight/);
|
||||
assert.match(tableModule, /function HeaderLabelInput/);
|
||||
assert.match(tableModule, /useInlineEdit/);
|
||||
assert.match(tableModule, /event\.target\.select/);
|
||||
assert.match(tableFormulaEngine, /export function evaluateTableCell/);
|
||||
assert.doesNotMatch(tableFormulaEngine, /Function\(/);
|
||||
|
|
@ -194,6 +207,7 @@ test("toolbox module registry and modules expose expected behavior", async () =>
|
|||
assert.match(timerModule, /Tabs/);
|
||||
assert.match(timerModule, /stopwatch/);
|
||||
assert.match(timerModule, /countdown/);
|
||||
assert.match(timerModule, /useInlineEdit/);
|
||||
assert.match(timerModule, /normalizeTimerData/);
|
||||
assert.match(taskPlannerModule, /export function TaskPlannerModule/);
|
||||
assert.match(taskPlannerModule, /normalizeTaskPlannerData/);
|
||||
|
|
@ -204,6 +218,8 @@ test("toolbox module registry and modules expose expected behavior", async () =>
|
|||
assert.match(taskPlannerModule, /categoryLabel/);
|
||||
assert.match(taskPlannerModule, /task-planner-warning/);
|
||||
assert.match(taskPlannerModule, /useGroupedReorder/);
|
||||
assert.match(taskPlannerModule, /useInlineEdit/);
|
||||
assert.match(taskPlannerModule, /commitOnEnter: false/);
|
||||
assert.match(taskPlannerModule, /reorderFeatures/);
|
||||
assert.doesNotMatch(taskPlannerModule, /canMoveItem:/);
|
||||
assert.doesNotMatch(taskPlannerModule, /canMoveGroup:/);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue